fix: reject was not called on timeout, decline and cancel scenarios #1576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, we don't call reject unless
reject: true
is passed on leave(). This was a recent change, so it caused a bug where reject was not called on timeout, decline, and cancel scenarios.There are four predefined reasons for rejecting the call:
busy
- when the callee is busy and cannot accept the call.decline
- when the callee intentionally declines the call.cancel
- when the caller cancels the call.timeout
- when the caller or callee rejects the call afterauto_cancel_timeout_ms
orincoming_call_timeout_ms
accordinglyWhat has been done
busy
yet. Will be part of Android telecom/callkit alignment I believe.incoming_call_timeout_ms
support has been added