Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reject was not called on timeout, decline and cancel scenarios #1576

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

santhoshvai
Copy link
Member

Background

Currently, we don't call reject unless reject: true is passed on leave(). This was a recent change, so it caused a bug where reject was not called on timeout, decline, and cancel scenarios.

There are four predefined reasons for rejecting the call:

  • busy - when the callee is busy and cannot accept the call.
  • decline - when the callee intentionally declines the call.
  • cancel - when the caller cancels the call.
  • timeout - when the caller or callee rejects the call after auto_cancel_timeout_ms or incoming_call_timeout_ms accordingly

What has been done

  • Reject is now called on timeout, decline and cancel scenarios. We dont handle busy yet. Will be part of Android telecom/callkit alignment I believe.
  • Added reason to reject API call
  • incoming_call_timeout_ms support has been added

@santhoshvai santhoshvai merged commit 8be76a4 into main Nov 14, 2024
15 of 17 checks passed
@santhoshvai santhoshvai deleted the reject-regression branch November 14, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants